Hi, On Fri, Aug 22, 2014 at 05:21:12PM +0200, Rasmus Villemoes wrote: > Felipe Balbi <balbi@xxxxxx> writes: > > > On Fri, Aug 22, 2014 at 04:44:33PM +0200, Rasmus Villemoes wrote: > >> Clearly this was meant to be an include guard, but a trailing > >> underscore was missing. It has been this way since the file was > >> introduced in 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver"). > >> > > > > right here you need to have: > > > > Fixes: 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver") > > Cc: <stable@xxxxxxxxxxxxxxx> > > Really? I can't see that it satisfies the > Documentation/stable_kernel_rules.txt. There's no chance of build error, since the > file is only included directly from a single .c file. As you can see on > LKML I've sent a few handfuls of similar patches all over the tree; IMHO > none of them qualify for stable. > > If you insist, I'll add the Fixes and Cc tags. it's a bug fix nevertheless. -- balbi
Attachment:
signature.asc
Description: Digital signature