On Fri, 22 Aug 2014, Christoph Hellwig wrote: > On Fri, Aug 22, 2014 at 10:53:42AM -0400, Alan Stern wrote: > > Good idea. An enhanced patch is below. If I can get a Tested-By: from > > Tiziano and one or two Acked-By: responses, I'll submit this for the > > current and stable kernels. > > > > Sending the initial INQUIRY command to LUNs larger than 0 involves a > > chicken-and-egg problem -- we don't know whether to fill in the LUN > > bits in the command until we know the SCSI level, and we don't know the > > SCSI level until the INQUIRY response is received. The solution we > > have been using is to store the most recently discovered level in the > > target structure, and use it as a default. If probing starts with LUN > > 0, and if all the LUNs have similar levels, this ought to work. > > > > Except for one thing: The code does store the default level in the > > scsi_target, but forgets to copy it back into each newly allocated > > scsi_device! I added a line to do that into the patch. > > Looks good to me, > > Acked-by: Christoph Hellwig <hch@xxxxxx> > > Do you want to queue this up in the USB tree? From the looks of what I > have on my plate so far it seems like we could avoid conflicts with it > in the SCSI tree. After hearing from Tiziano, I'll submit the patch to the SCSI tree. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
