Hi, On Mon, Aug 11, 2014 at 08:32:37AM -0500, Felipe Balbi wrote: > Hi, > > On Mon, Aug 11, 2014 at 01:15:06PM +0200, Michael Grzeschik wrote: > > As the driver is mainline we can remove the version numbers. > > > > Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> > > --- > > drivers/usb/gadget/uvc.h | 3 --- > > drivers/usb/gadget/uvc_v4l2.c | 1 - > > 2 files changed, 4 deletions(-) > > > > diff --git a/drivers/usb/gadget/uvc.h b/drivers/usb/gadget/uvc.h > > index 49d9573..e593a10 100644 > > --- a/drivers/usb/gadget/uvc.h > > +++ b/drivers/usb/gadget/uvc.h > > @@ -96,9 +96,6 @@ extern unsigned int uvc_gadget_trace_param; > > * Driver specific constants > > */ > > > > -#define DRIVER_VERSION "0.1.0" > > -#define DRIVER_VERSION_NUMBER KERNEL_VERSION(0, 1, 0) > > - > > #define UVC_NUM_REQUESTS 16 > > #define UVC_MAX_REQUEST_SIZE 64 > > #define UVC_MAX_EVENTS 4 > > diff --git a/drivers/usb/gadget/uvc_v4l2.c b/drivers/usb/gadget/uvc_v4l2.c > > index 58633bf..65af2f8 100644 > > --- a/drivers/usb/gadget/uvc_v4l2.c > > +++ b/drivers/usb/gadget/uvc_v4l2.c > > @@ -194,7 +194,6 @@ uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg) > > strlcpy(cap->card, cdev->gadget->name, sizeof(cap->card)); > > strlcpy(cap->bus_info, dev_name(&cdev->gadget->dev), > > sizeof cap->bus_info); > > - cap->version = DRIVER_VERSION_NUMBER; > > did you run v4l2-compliance ? IIRC it will fail if you don't provide > cap->version. True! Is it right to change it to LINUX_VERSION_CODE as v4l_querycap? I was unsure as checkpatch was barfing about using this. Thanks, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
