Hi Arnd, Thanks for reviewing, see my comments below: - > > Changes since v2: > > - Based on Arnd Berghman feedback, split out into 2 devices / drivers > > - Base drivers oh ehci-platform.c & ohci-platform.c with required extensions > > to allow possible re-merge in the furture. > > Hi Peter, > > This looks much better than the first version. I have some remaining comments for > how it could be simplified a bit more. Yes I think I've addressed these now in V4, which I will send in a moment. > > The way that you deal with the 48mhz clock seems like it should fit in well > with the generic driver, just like all the rest (once the usb-st-common > stuff is moved into the ohci/ehci drivers), so the alternative would be > to make it all generic now. Yes I tried to do it in a way which would, however I would prefer not to merge into the generic one for now because: - 1) There are some other subtle changes versus the generic drivers. For example in power_on() and power_off() I put the IP into reset and power down, which isn't done in the generic driver. Also with this IP it needs power signal asserted before reset, otherwise it can hang the chip. 2) I don't have any of the other hardware which uses ehci-platform / ohci-platform to test I haven't broken things. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
