Kever, On Tue, Aug 5, 2014 at 6:01 PM, Kever Yang <kever.yang@xxxxxxxxxxxxxx> wrote: > According to the "dr_mode", the otg controller can work as > device role and host role. Some boards always want to use host mode > and some other boards want to use gadget mode. We use the dts setting > to set dwc2's mode, rather than fixing it to whatever hardware says. > > Signed-off-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx> > Acked-by: Paul Zimmerman <paulz@xxxxxxxxxxxx> > --- > > Changes in v4: > - From Doug's suggestion: > -- remove dr_mode init from Kconfig code > -- change the commit meesage > > Changes in v3: > - fix the odd spacing in dwc2_hsotg struct > - From Jingoo's suggestion: > change the commit message > - add dr_mode init from Kconfig > > Changes in v2: > - put spaces around '+' operator > - expand the comment for dr_mode > - handle dr_mode is USB_DR_MODE_OTG > > drivers/usb/dwc2/core.c | 18 ++++++++++++++++++ > drivers/usb/dwc2/core.h | 5 +++++ > drivers/usb/dwc2/platform.c | 4 ++++ > 3 files changed, 27 insertions(+) I don't know the driver well enough to feel like I can add my Reviewed-by tag, but since you've already got an Ack from Paul it doesn't matter much. ...FWIW I'm happy with the current state of the code now. :) -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
