Re: [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 03-08-2014 6:56, Nicholas Krause wrote:

This changes the ifdef statement  in sg_set_bg to !CONFIG_DEBUG_SG in order
to avoid a bug with xhci dequence/enquence functions.

   dequeue/enqueue?

Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
---
  include/linux/scatterlist.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h
index adae88f..62de7b3 100644
--- a/include/linux/scatterlist.h
+++ b/include/linux/scatterlist.h
@@ -111,7 +111,7 @@ static inline struct page *sg_page(struct scatterlist *sg)
  static inline void sg_set_buf(struct scatterlist *sg, const void *buf,
  			      unsigned int buflen)
  {
-#ifdef CONFIG_DEBUG_SG
+#ifdef !CONFIG_DEBUG_SG

Didn't you mean #ifndef instead? I guess you didn't even try to build-test this.

  	BUG_ON(!virt_addr_valid(buf));
  #endif
  	sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf));

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux