On 7/31/14, 5:00 PM, Paul Zimmerman wrote: >> From: Paul Zimmerman >> Sent: Wednesday, July 30, 2014 11:29 AM >> >>> From: dinguyen@xxxxxxxxxx [mailto:dinguyen@xxxxxxxxxx] >>> Sent: Wednesday, July 30, 2014 8:21 AM >>> >>> Adds the gadget data structure and appropriate data structure pointers >>> to the common dwc2_hsotg data structure. This is needed so that the >>> dwc2_hsotg data structure can be used by the hcd and gadget drivers. >>> >>> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx> >>> --- >>> drivers/usb/dwc2/core.h | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h >>> index 3b4bd4c..ee34ee1 100644 >>> --- a/drivers/usb/dwc2/core.h >>> +++ b/drivers/usb/dwc2/core.h >>> @@ -604,6 +604,12 @@ struct dwc2_hsotg { >>> struct timer_list wkp_timer; >>> enum dwc2_lx_state lx_state; >>> >>> + /* Gadget structures */ >>> + struct s3c_hsotg *s3c_hsotg; >>> + struct usb_gadget gadget; >>> + struct usb_gadget_driver *driver; >>> + struct s3c_hsotg_ep *eps; >> What's up with the funny spacing here? Can you neaten that up, please? > Also, you need another patch later in the series, to remove the > 'gadget', 'driver', and 'eps' members from the s3c_hsotg struct, once > they are no longer used. Or did you do that later and I missed it? > Also, I think there are some more members, like 'regs', that are unused > at the end of the series, right? I believe so. I'll make sure to address this in V3. > And, I think the 'dedicated_fifos' member is the same thing as the > 'en_multiple_tx_fifo' member on the host side, so perhaps that could > be removed as well? That could be done in a future patch, though. > I'll see if it can be removed cleanly in this series. Dinh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
