Re: [RFTv3 PATCH] xhci: rework cycle bit checking for new dequeue pointers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/30/2014 07:00 PM, Evan Langlois wrote:
> Just an update.  I added the TRUST_TX_LENGTH quirk for my chipset and
> the remaining errors have gone away.  The combination of the RTF and
> this together seems to fix a lot.  The only way I can reproduce
> anything similar to the problems I had before is to unplug the USB
> tuner while its in use! <<if it hurts when you do that, don't do
> that>>  However, it doesn't "screw up" anything internally.  I needed
> a reboot to get USB functioning before, and I wasn't unplugging
> anything when it was live.  Now I can just plug it back in and restart
> the application and it works fine like nothing ever happened.  If
> anyone wants to see the log as to what it says when I unplug it, I
> saved it.
> 
> Should I submit a patch for the TRUST_TX_LENGTH quirk?   Its PCI
> vendor 1022 (AMD), and the XHCI controller is 7814.  It shows up as
> rev 09, so I wrote it to only set the quirk for this revision.  I
> don't know if other revisions other than mine need it.  In fact, I'll
> just attach it here.
> 
>

That's good news, I think it's sage to add the quirk for all AMD FCH USB XHCI Controllers, (1022:7814)
not just revision 09

I can add the quirk, unless you want to send it, in your name, with a commit message and signed-off line.
I think we can expect it to fail when ripped out in mid use.

Nice to get this working, thanks for reporting and testing this

-Mathias
 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux