On Fri, Jul 25, 2014 at 10:01:52PM -0700, Greg KH wrote: > On Fri, Jul 25, 2014 at 11:19:05AM -0500, Felipe Balbi wrote: > > When we're debugging hard-to-reproduce and time-sensitive > > use cases, printk() poses too much overhead. That's when > > the kernel's tracing infrastructure comes into play. > > > > This patch implements a few initial tracepoints for the > > dwc3 driver. More traces can be added as necessary in order > > to ease the task of debugging dwc3. > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > --- > > > > Hi folks, > > > > I have been meaning to send this for quite a while now but > > never had the time to test everything and make sure it works. > > > > Logs are looking pretty good to my eyes with a much smaller > > overhead than with dev_* macros. > > > > If you have a real good reason to add more logs, just let > > me know and we will look at the possibility for adding it, > > I have a feeling people will want traces for endpoint 0 > > state machine but I'm not entirely sure it's needed, so I > > left it out for now. If folks think it's important, I'll add > > it in no time. > > > > Please give it a good review because we will have to support > > tracepoints for the next 60 years. > > Can you delete the dev_vdbg() calls at the same place as well? Sure, I guess I could. -- balbi
Attachment:
signature.asc
Description: Digital signature
