Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/23/2014 05:24 AM, Nick Krause wrote:
On Tue, Jul 22, 2014 at 8:44 PM, Sasha Levin <sashal@xxxxxxxxxx> wrote:
On 07/18/2014 10:52 PM, Nick Krause wrote:
Please explain exactly why it's not needed, why it can never be NULL, and
what prevents it from being NULL.

"after dicussing" (do you run spellcheck on your mails?) won't mean anything
to someone looking at this commit in a year.

Your commit message also mentions usb_device which has nothing to do with
your patch.


Thanks,
Sasha

Sasha ,
Greg seems to have signed it off.
Cheers Nick

Greg?

Even if the patch is correct (and I'm not saying it is) the commit message is way off.


Thanks,
Sasha


Sasha,
The patch is in the  kernel now.

Greg's tree is not Linus' tree, so it's not set to stone in git commit history yet.

> I am not going through the trouble of removing
it, if you want to fix the commit message go on ahead.
Nick

This kind of attitude might significantly lower your chances of future patches being accepted.

Vlastimil


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux