On Thursday, July 24, 2014 4:11 AM, Dinh Nguyen wrote: > On 7/23/14, 1:03 PM, Paul Zimmerman wrote: > >> From: Dinh Nguyen [mailto:dinh.linux@xxxxxxxxx] > >> Sent: Wednesday, July 23, 2014 8:12 AM > >> > >> On 07/16/2014 04:27 PM, Paul Zimmerman wrote: > >>>> From: dinguyen@xxxxxxxxxx [mailto:dinguyen@xxxxxxxxxx] > >>>> Sent: Wednesday, July 16, 2014 1:33 PM > >>>> > >>>> Puts back "samsung,s3c6400-hsotg" into the dwc2_of_match_table[]. > >>> Why? > >>> > >> This compatible binding was originally in the gadget driver. Don't I > >> want to put it back into the platform binding table? > > Do you mean you accidently deleted it in one of your previous patches? > > If so, then yes you should put it back. But your commit message should > > explain that, so other people know why it is being done. > > > Yes, I had to removed s3c_hsotg_of_ids[] in patch 3/12. I think I had to > do this > to enable that patch to build. Hi Dinh Nguyen, I see what you mean. I agree with Paul Zimmerman's opinion. It looks better to add more detailed commit message, because it allows people to know the reason more easily. :-) Thank you. Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
