I think I understand your concern now. You mean that I am only adding a quirk for the devices with their interval reported as microframes. After reading the code comments about many other vendors having similar issues, I thought it was more complete, and potentially less confusing, for the bInterval as frames case to be supported as well. If you prefer, I can remove the unused quirk and resubmit. Before I do, can you give me some guidance on the correct dev_warn policy. I see many instances of dev_warn like the example below. dev_warn(ddev, "config %d interface %d altsetting %d " "endpoint 0x%X is Bulk; changing to Interrupt\n", cfgno, inum, asnum, d->bEndpointAddress); endpoint->desc.bmAttributes = USB_ENDPOINT_XFER_INT; endpoint->desc.bInterval = 1; if (usb_endpoint_maxp(&endpoint->desc) > 8) endpoint->desc.wMaxPacketSize = cpu_to_le16(8); However, checkpatch seems to be very unhappy with these due to the line breaks in the strings. As well, the code guidelines seem to frown on these because you can't grep for them. I shortened my dev_warn to comply with 80 cols and no line breaks, but this make it less consistent with the other ones in that section. Which do you prefer? Regards Jim Michels -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
