Am 2014-07-22 04:22, schrieb Shawn Guo:
> On Fri, Jul 18, 2014 at 07:01:37PM +0200, Stefan Agner wrote:
>> This adds USB PHY and USB controller nodes. Vybrid SoCs have two
>> independent USB cores which each supports DR (dual role). However,
>> real OTG is not supported since the OTG ID pin is not available.
>>
>> The PHYs are located within the anadig register range, hence we need
>> to change the length of the anadig registers.
>>
>> Signed-off-by: Stefan Agner <stefan@xxxxxxxx>
>> ---
>> arch/arm/boot/dts/vf610.dtsi | 46 +++++++++++++++++++++++++++++++++++++++++---
>> 1 file changed, 43 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
>> index 6a6190c..f6c3f02 100644
>> --- a/arch/arm/boot/dts/vf610.dtsi
>> +++ b/arch/arm/boot/dts/vf610.dtsi
>> @@ -25,6 +25,8 @@
>> gpio2 = &gpio3;
>> gpio3 = &gpio4;
>> gpio4 = &gpio5;
>> + usbphy0 = &usbphy0;
>> + usbphy1 = &usbphy1;
>> };
>>
>> cpus {
>> @@ -285,9 +287,25 @@
>> gpio-ranges = <&iomuxc 0 128 7>;
>> };
>>
>> - anatop@40050000 {
>> - compatible = "fsl,vf610-anatop";
>> - reg = <0x40050000 0x1000>;
>> + anatop: anatop@40050000 {
>> + compatible = "fsl,vf610-anatop", "syscon";
>> + reg = <0x40050000 0x400>;
>> + };
>> +
>> + usbphy0: usbphy@40050800 {
>> + compatible = "fsl,vf610-usbphy", "fsl,imx23-usbphy";
>
> Since phy driver will match "fsl,vf610-usbphy" anyway, we do not need
> "fsl,imx23-usbphy" here.
<snip>
>> @@ -309,6 +327,18 @@
>> reg = <0x4006b000 0x1000>;
>> #clock-cells = <1>;
>> };
>> +
>> + usbdev0: usb@40034000 {
>> + compatible = "fsl,imx6q-usb", "fsl,imx27-usb";
>
> It doesn't really make any sense to have "fsl,imx6q-usb" here. The
> following one should be less confusing.
>
> compatible = "fsl,vf610-usb", "fsl,imx27-usb";
I don't quite understand the rule here, when do we drop compatible you
suggest in fsl,imx23-usbphy and when do we keep the "fallback" as we do
for the USB controller?
Documentation/devicetree/bindings/usb/mxs-phy.txt says:
> "fsl,imx23-usbphy" is still a fallback for other strings
And Documentation/devicetree/bindings/usb/ci-hdrc-imx.txt says:
> - compatible: Should be "fsl,imx27-usb"
--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
