Re: [PATCH] gpio:gpio-pl2303: add gpio driver for GPIOs on PL2303

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> +#include <linux/slab.h>
> +#include <linux/usb.h>
> +#include <linux/gpio.h>



> +	pl2303_gpio_write(&pl2303_gpio->gpio_chip);
> +
> +	ret = gpiochip_add(&pl2303_gpio->gpio_chip);
> +	if (ret < 0) {


AFAICS that stuff is conditional:ed by #ifdef CONFIG_GPIOLIB in
gpio.h (or rather, its internally included asm-generic/gpio.h)

Thus

> +config GPIO_PL2303
> +	tristate "USB Prolific 2303 gpio support"
> +	depends on USB_SERIAL_PL2303
> +	help
> +	  Enable support for GPIOs on USB Prolific 2303
> +	  It support two GPIOs on PL2303HX currently.

quite likely a
	depends on GPIOLIB && ...
is missing here (as is done with several other GPIO support drivers
in the same Kconfig)

Thanks for this nicely functionality-enhancing serial driver addition,

Andreas Mohr
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux