Re: [PATCH -next] usb: gadget: Remove redundant dev_err call in r8a66597_sudmac_ioremap()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wei,

Thank you for the patch.

On Sunday 20 July 2014 20:30:14 weiyj_lk@xxxxxxx wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>

Acked-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

> ---
>  drivers/usb/gadget/udc/r8a66597-udc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c
> b/drivers/usb/gadget/udc/r8a66597-udc.c index 4600842..68a7d20 100644
> --- a/drivers/usb/gadget/udc/r8a66597-udc.c
> +++ b/drivers/usb/gadget/udc/r8a66597-udc.c
> @@ -1846,10 +1846,8 @@ static int r8a66597_sudmac_ioremap(struct r8a66597
> *r8a66597,
> 
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sudmac");
>  	r8a66597->sudmac_reg = devm_ioremap_resource(&pdev->dev, res);
> -	if (IS_ERR(r8a66597->sudmac_reg)) {
> -		dev_err(&pdev->dev, "ioremap error(sudmac).\n");
> +	if (IS_ERR(r8a66597->sudmac_reg))
>  		return PTR_ERR(r8a66597->sudmac_reg);
> -	}
> 
>  	return 0;
>  }

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux