Re: [PATCH] usbcore: don't log on consecutive debounce failures of the same port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 18, 2014 at 08:48:19AM +0200, Oliver Neukum wrote:
> On Thu, 2014-07-17 at 17:13 -0700, Greg KH wrote:
> > On Mon, Jul 14, 2014 at 10:47:55PM +0200, Oliver Neukum wrote:
> 
> > > I see no sane way to come up with numbers.
> > > Unless you want to measure the time between spurious event.
> > > But that would really be overkill. I'd rather fix a concrete
> > > issue.
> > 
> > I'm all for fixing a "real" issue, but not at the expense of getting it
> > wrong.
> > 
> > What hardware is "broken" here?  Can we blacklist it somehow instead of
> > being so general here?
> 
> There's more than a dozen laptops with this issue out there.
> The tests turned out quite specific. The issue only occurs
> when rfkill is used to switch off BT. As different types of laptops
> are affected the port number is unpredictable.
> 
> IMHO my patch is quite specific to the issue at hand. It catches
> the issue fairly specific, namely noise on one port, without totally
> hiding it and if it is a different issue with multiple affected
> ports, the messages will not be surpressed.
> And that without the need for yet another blacklist.

Ok, I'll take it as-is, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux