On Fri, 18 Jul 2014, Nicholas Krause wrote: > I am removing two fix mes in this file as after dicussing then it seems > there is no reason to check against Null for usb_device as it can never > be NULL and this is check is therefore not needed. > > Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx> > --- > drivers/usb/core/hcd.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > index bec31e2..487abcf 100644 > --- a/drivers/usb/core/hcd.c > +++ b/drivers/usb/core/hcd.c > @@ -855,8 +855,6 @@ static ssize_t authorized_default_show(struct device *dev, > struct usb_bus *usb_bus = rh_usb_dev->bus; > struct usb_hcd *usb_hcd; > > - if (usb_bus == NULL) /* FIXME: not sure if this case is possible */ > - return -ENODEV; > usb_hcd = bus_to_hcd(usb_bus); > return snprintf(buf, PAGE_SIZE, "%u\n", usb_hcd->authorized_default); > } > @@ -871,8 +869,6 @@ static ssize_t authorized_default_store(struct device *dev, > struct usb_bus *usb_bus = rh_usb_dev->bus; > struct usb_hcd *usb_hcd; > > - if (usb_bus == NULL) /* FIXME: not sure if this case is possible */ > - return -ENODEV; > usb_hcd = bus_to_hcd(usb_bus); > result = sscanf(buf, "%u\n", &val); > if (result == 1) { Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html