Hi, On 07/18/2014 04:13 PM, David Laight wrote: > From: Hans de Goede >> To help debugging xhci problems. >> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> --- >> drivers/usb/host/xhci.c | 4 ++++ >> drivers/usb/host/xhci.h | 2 ++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c >> index 7436d5f..7d02e1b 100644 >> --- a/drivers/usb/host/xhci.c >> +++ b/drivers/usb/host/xhci.c >> @@ -4867,6 +4867,10 @@ int xhci_gen_setup(struct usb_hcd *hcd, xhci_get_quirks_t get_quirks) >> if (retval) >> goto error; >> xhci_dbg(xhci, "Called HCD init\n"); >> + >> + xhci_info(xhci, "hcc params 0x%08x hci version 0x%x quirks 0x%08x\n", >> + xhci->hcc_params, xhci->hci_version, xhci->quirks); >> + >> return 0; > > You might as well remove the xhci_dbg() line as well. > No need for both traces. That one is balanced with xhci_dbg(xhci, "Calling HCD init\n"); so it seems sensible to keep it. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html