Hello Jim Baxter,
This is a semi-automatic email about new static checker warnings.
The patch 6d3865f9d41f: "usb: gadget: NCM: Add transmit multi-frame."
from Jul 7, 2014, leads to the following Smatch complaint:
drivers/usb/gadget/function/u_ether.c:564 eth_start_xmit()
error: we previously assumed 'dev->port_usb' could be null (see line 557)
drivers/usb/gadget/function/u_ether.c
556 spin_lock_irqsave(&dev->lock, flags);
557 if (dev->port_usb)
^^^^^^^^^^^^^
Old check.
558 skb = dev->wrap(dev->port_usb, skb);
559 spin_unlock_irqrestore(&dev->lock, flags);
560 if (!skb) {
561 /* Multi frame CDC protocols may store the frame for
562 * later which is not a dropped frame.
563 */
564 if (dev->port_usb->supports_multi_frame)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Patch adds unchecked dereference.
565 goto multiframe;
566 goto drop;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
