Julius, I have done the testing; sorry for one day delay. I bought some new hardware and was busy assembling test rigs; the end result is that I was able to test four USB 3.0 controllers : Intel (Z97 chipset), NEC uPD720200 and two Asmedia. I tested two kernel versions: 3.2.61 and 3.16.0-rc5, both with and without your patch. I used three devices: Areca ARC-5040 RAID enclosure, WD MyPassport 2TB external drive and Transcend flash drive. All are USB 3.0 devices, and two former were problematic on Asmedia controllers, while the flash drive worked fine with all controllers and kernels. The results are that your patch fixes the problem for all devices, and seems to work fine on all controllers. On an unpatched 3.2.61 kernel both Asmedia controllers were causing problems (when "problematic" devices were plugged in). Kernel 3.16.0-rc5 worked fine for all hardware combinations, with and without a patch, and same can be said about patched 3.2.61. I am sending "Tested-by" reply to LKML. Thank you very much for your help, I really appreciate it. Maciej Puzio PS. Julius, apology for duplicated email; clicked "reply" instead of "reply to all". On Tue, Jul 15, 2014 at 1:53 PM, Julius Werner <jwerner@xxxxxxxxxxxx> wrote: > Hi Maciej, > > On Tue, Jul 15, 2014 at 11:29 AM, Maciej Puzio <mx34567@xxxxxxxxx> wrote: >> Julius, I tested the patch on kernel 3.2.61, on two USB 3.0 host >> controllers (Asmedia and NEC), and four USB 3.0 devices (three of >> which were previously triggering the issue, and one worked fine). On >> the Asmedia controller, the patch fixes the regression, but with one >> of the devices (Areca ARC-5040) I still occasionally get the following >> messages in the log: >> >> Jul 15 12:34:50 ubuntu kernel: [ 1855.902804] usb 4-1: reset >> SuperSpeed USB device number 2 using xhci_hcd >> Jul 15 12:34:50 ubuntu kernel: [ 1855.920190] xhci_hcd 0000:03:00.0: >> xHCI xhci_drop_endpoint called with disabled ep ffff880423628480 >> Jul 15 12:34:50 ubuntu kernel: [ 1855.920197] xhci_hcd 0000:03:00.0: >> xHCI xhci_drop_endpoint called with disabled ep ffff8804236284c0 >> >> These messages appear out of nowhere, seemingly without any cause, >> usually some time after the device has been plugged in (time varies >> from 30 sec to 30 min). This worries me a little, because these exact >> messages were one of the symptoms of the regression. However, the >> device seems to work fine and remains accessible. Without your patch, >> such messages were logged every 30 seconds, and the device was not >> accessible until they stopped. >> I did not notice any problems with other devices on the Asmedia >> controller (with the patch), nor with any devices on the NEC >> controller (with or without the patch). > > I *think* those messages are harmless. I've seen them often enough in > other logs, they shouldn't have anything to do with this bug. You > would probably see them without either of my two patches as well. > >> I have not yet tested any other kernel version; I intend to compile >> and test the newest available kernel tomorrow. Where should I add the >> "Tested-by" tag? > > Just respond with 'Tested-by: Your Name <email>' to the patch email > and the the maintainer should merge that into the commit message when > he picks it up (at least that's how I've seen this done before). On Tue, Jul 15, 2014 at 1:53 PM, Julius Werner <jwerner@xxxxxxxxxxxx> wrote: > Hi Maciej, > > On Tue, Jul 15, 2014 at 11:29 AM, Maciej Puzio <mx34567@xxxxxxxxx> wrote: >> Julius, I tested the patch on kernel 3.2.61, on two USB 3.0 host >> controllers (Asmedia and NEC), and four USB 3.0 devices (three of >> which were previously triggering the issue, and one worked fine). On >> the Asmedia controller, the patch fixes the regression, but with one >> of the devices (Areca ARC-5040) I still occasionally get the following >> messages in the log: >> >> Jul 15 12:34:50 ubuntu kernel: [ 1855.902804] usb 4-1: reset >> SuperSpeed USB device number 2 using xhci_hcd >> Jul 15 12:34:50 ubuntu kernel: [ 1855.920190] xhci_hcd 0000:03:00.0: >> xHCI xhci_drop_endpoint called with disabled ep ffff880423628480 >> Jul 15 12:34:50 ubuntu kernel: [ 1855.920197] xhci_hcd 0000:03:00.0: >> xHCI xhci_drop_endpoint called with disabled ep ffff8804236284c0 >> >> These messages appear out of nowhere, seemingly without any cause, >> usually some time after the device has been plugged in (time varies >> from 30 sec to 30 min). This worries me a little, because these exact >> messages were one of the symptoms of the regression. However, the >> device seems to work fine and remains accessible. Without your patch, >> such messages were logged every 30 seconds, and the device was not >> accessible until they stopped. >> I did not notice any problems with other devices on the Asmedia >> controller (with the patch), nor with any devices on the NEC >> controller (with or without the patch). > > I *think* those messages are harmless. I've seen them often enough in > other logs, they shouldn't have anything to do with this bug. You > would probably see them without either of my two patches as well. > >> I have not yet tested any other kernel version; I intend to compile >> and test the newest available kernel tomorrow. Where should I add the >> "Tested-by" tag? > > Just respond with 'Tested-by: Your Name <email>' to the patch email > and the the maintainer should merge that into the commit message when > he picks it up (at least that's how I've seen this done before). -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
