Re: [RFC PATCH 2/3 ] usb: phy: msm: Make phy_reset clk and reset line optional.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 17/07/14 15:39, Felipe Balbi wrote:
Hi,

On Thu, Jul 17, 2014 at 02:14:15PM +0100, Srinivas Kandagatla wrote:
On 17/07/14 13:54, pramod gurav wrote:
Hi Srini,

On Thu, Jul 17, 2014 at 6:19 PM,  <pramod.gurav.etc@xxxxxxxxx> wrote:
From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>

This patch makes the phy reset clk and reset line optional as this clk
is not available on boards like IFC6410 with APQ8064.

.
[snip]
.

         pdata->mode = of_usb_get_dr_mode(node);
         if (pdata->mode == USB_DR_MODE_UNKNOWN)
@@ -1556,7 +1556,7 @@ static int msm_otg_probe(struct platform_device *pdev)
                                            np ? "phy" : "usb_phy_clk");
         if (IS_ERR(motg->phy_reset_clk)) {
                 dev_err(&pdev->dev, "failed to get usb_phy_clk\n");

I keep getting this error on IFC6410. Cant we suppress it?
IMO, We should ignore this message for IFC 6410 board as they do not have
phy reset clk.

looks like that should become a dev_dbg() then ?

Sure, I agree.

I will resend the patch with dev_dbg.

--srini
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux