Hi, On Tue, Jul 15, 2014 at 01:09:23PM +0200, Andrzej Pietrasiewicz wrote: > If gadget g_*.ko modules are built-in their initialization happens before > libcomposite is initialized. This results in e.g. g_ether not initializing > if compiled-in. This patch fixes the order modules are > built, so that they are initialized in proper order when built-in. > > Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx> > --- > @Felipe: I'm also sending a v4 series which corrects this problem > from the beginning (unlike this patch which fixes things afterwards) > so that you can choose which fits better. > > drivers/usb/gadget/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile > index 319500f..4fdac2f 100644 > --- a/drivers/usb/gadget/Makefile > +++ b/drivers/usb/gadget/Makefile > @@ -5,7 +5,8 @@ subdir-ccflags-$(CONFIG_USB_GADGET_DEBUG) := -DDEBUG > subdir-ccflags-$(CONFIG_USB_GADGET_VERBOSE) += -DVERBOSE_DEBUG > ccflags-y += -I$(PWD)/drivers/usb/gadget/udc > > -obj-$(CONFIG_USB_GADGET) += legacy/ udc/ function/ > obj-$(CONFIG_USB_LIBCOMPOSITE) += libcomposite.o > libcomposite-y := usbstring.o config.o epautoconf.o > libcomposite-y += composite.o functions.o configfs.o u_f.o > + > +obj-$(CONFIG_USB_GADGET) += udc/ function/ legacy/ now that my tree is closed you send me this note ? I'll pick this during the -rc cycle. Considering that built-in gadget drivers have been broken for such a long time, we can wait a few more days. Just make sure to test my 'next' branch on your end, and/or linux-next starting tomorrow or the day after. thanks -- balbi
Attachment:
signature.asc
Description: Digital signature
