On Mon, Jul 14, 2014 at 11:49:38AM +0530, Kishon Vijay Abraham I wrote: > Greg, > > On Thursday 05 June 2014 06:22 PM, Heikki Krogerus wrote: > > This allows resources such as GPIOs and clocks, which can be > > matched based on the device name when requested, to be > > assigned even when PLATFORM_DEVID_AUTO is used. > > Any comments on this patch? I thought I rejected it in the past, don't have my email archives around at the moment, sorry. > > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > --- > > drivers/base/platform.c | 77 ++++++++++++++++++++++++++++++------------------- > > 1 file changed, 47 insertions(+), 30 deletions(-) > > > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > > index 9e9227e..e856bc4 100644 > > --- a/drivers/base/platform.c > > +++ b/drivers/base/platform.c > > @@ -177,11 +177,45 @@ struct platform_object { > > */ > > void platform_device_put(struct platform_device *pdev) > > { > > - if (pdev) > > - put_device(&pdev->dev); > > + if (!pdev) > > + return; > > + > > + if (pdev->id_auto) { > > + ida_simple_remove(&platform_devid_ida, pdev->id); > > + pdev->id = PLATFORM_DEVID_AUTO; > > + } > > + > > + put_device(&pdev->dev); > > } > > EXPORT_SYMBOL_GPL(platform_device_put); Why would a single call to this function remove an id? That seems really wrong, you should be able to call get and put on a device numerous times, only the "last" reference should cause the device to be cleaned up. Shouldn't this be in the release function instead? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html