On Wed, Jul 9, 2014 at 2:08 AM, Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxx> wrote:
>
> Hi Ulrich
>
> Thank you for your patch
Thank you for your review.
>> @@ -186,6 +192,8 @@ struct renesas_usbhs_platform_info {
>> * driver use these param for some register
>> */
>> struct renesas_usbhs_driver_param driver_param;
>> +
>> + struct usb_phy *phy;
>> };
>
> Using renesas_usbhs_platform_info for *phy is not good idea from my point of view.
> Because its memory is located on platform side.
> (this is the reason why usbhs_probe() using memcpy() for getting info->xxx)
>
> I guess struct usbhs_priv is good place,
> and you can use usbhs_pdev_to_priv() for this purpose ?
Yes, that seems more natural anyway.
CU
Uli
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
