On Mon, Jul 07 2014, Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx> wrote:
> ffs_do_desc() handles one descriptor, while ffs_do_descs() handles a number
> of descriptors. The tho names are so similar that it causes confusion.
> Rename to reflect their purpose better.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
Thanks.
> ---
> drivers/usb/gadget/function/f_fs.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
> index 88d6fa2..e1b2ddd 100644
> --- a/drivers/usb/gadget/function/f_fs.c
> +++ b/drivers/usb/gadget/function/f_fs.c
> @@ -1649,8 +1649,9 @@ typedef int (*ffs_entity_callback)(enum ffs_entity_type entity,
> struct usb_descriptor_header *desc,
> void *priv);
>
> -static int __must_check ffs_do_desc(char *data, unsigned len,
> - ffs_entity_callback entity, void *priv)
> +static int __must_check ffs_do_single_desc(char *data, unsigned len,
> + ffs_entity_callback entity,
> + void *priv)
> {
> struct usb_descriptor_header *_ds = (void *)data;
> u8 length;
> @@ -1802,7 +1803,7 @@ static int __must_check ffs_do_descs(unsigned count, char *data, unsigned len,
> if (!data)
> return _len - len;
>
> - ret = ffs_do_desc(data, len, entity, priv);
> + ret = ffs_do_single_desc(data, len, entity, priv);
> if (unlikely(ret < 0)) {
> pr_debug("%s returns %d\n", __func__, ret);
> return ret;
> --
> 1.8.3.2
>
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@xxxxxxxxxx>--<xmpp:mina86@xxxxxxxxxx>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
