Re: [PATCH] USB: EHCI: don't allocate hardware periodic table atomically by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 3 Jul 2014, Vladimir Zapolskiy wrote:

> ehci_mem_init() is executed one time during ehci_init() and by default
> all memory allocations but ehci->periodic are done not atomically,
> GFP_KERNEL is passed as flags parameter.
> 
> Do similar allocation for ehci->periodic and free some space in
> coherent atomic DMA pool by default.
> 
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx>
> 
> ---
>  drivers/usb/host/ehci-mem.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-mem.c b/drivers/usb/host/ehci-mem.c
> index c0fb6a8..b6205fa 100644
> --- a/drivers/usb/host/ehci-mem.c
> +++ b/drivers/usb/host/ehci-mem.c
> @@ -209,7 +209,7 @@ static int ehci_mem_init (struct ehci_hcd *ehci, gfp_t flags)
>  	ehci->periodic = (__le32 *)
>  		dma_alloc_coherent (ehci_to_hcd(ehci)->self.controller,
>  			ehci->periodic_size * sizeof(__le32),
> -			&ehci->periodic_dma, 0);
> +			&ehci->periodic_dma, flags);
>  	if (ehci->periodic == NULL) {
>  		goto fail;
>  	}

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

Please make the same change in ohci-hcd.c and uhci-hcd.c.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux