On 07/01/2014 03:08 PM, Tuomas Tynkkynen wrote: > tegra_usb_phy_close() is supposed to undo the effects of > tegra_usb_phy_init(). It is also currently added as the USB PHY shutdown > callback, which is wrong, since tegra_usb_phy_init() is only called > during probing wheras the shutdown callback can get called multiple > times. This then leads to warnings about unbalanced regulator_disable if > the EHCI driver is unbound and bound again at runtime. The series, Reviewed-by: Stephen Warren <swarren@xxxxxxxxxx> > diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c > -static void tegra_usb_phy_close(struct usb_phy *x) > +static void tegra_usb_phy_close(struct tegra_usb_phy *phy) If this function undoes what _init does, it seems it should be called _fini not _close. But that's bike-shedding perhaps. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
