On 01/07/2014 at 16:30:08 +0800, Peter Chen wrote : > > >>Well, there is nothing specific about the Berlin CI. Some subsystems > > >>use the 'generic' keyword in these cases. Do you see a particular reason > > >>I should use some Berlin related compatible here? > > > > > >Not must, one suggestion is: can you change the compatible string > > >to "chipidea-usb-generic"? > > > > I don't know about ChipIdea/ARC/DW's product portfolio but I guess > > the compatible should also carry '2.0' or 'usb2' in it. Or we just > > use some version number like 'chipidea,ci13000' or 'chipidea,ci13xxx'. > > > > The recommended format for compatible string is: "manufacturer,model", > I agree with "chipidea,ci13xxx", thanks. > I think we should probably avoid using wildcards in the compatible string. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html