Hello, On Tue, Jun 24, 2014 at 07:51:01PM +0900, Jingoo Han wrote: > On Tuesday, June 24, 2014 7:35 PM, Antoine Tenart wrote: > > > > Add a generic ChipIdea driver, with optional PHY and clock, to support > > ChipIdea controllers that doesn't need specific functions. > > s/doesn't/don't > > > > > Needed for the Marvell Berlin SoCs SUB controllers. > > s/SUB/USB Right, I'll fix these. > > > + > > +MODULE_DESCRIPTION("Generic ChipIdea HDRC USB binding"); > > +MODULE_AUTHOR("Antoine Ténart <antoine.tenart@xxxxxxxxxxxxxxxxxx>"); > > +MODULE_LICENSE("GPL"); > > How about "GPL v2"? Well, "GPL" stands for "GNU Public License v2 or later" as documented in: http://lxr.free-electrons.com/source/include/linux/module.h#L100 Is there a reason I should use "GPLv2"? Or is this a best practice? Thanks! Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html