Re: [PATCH v3 4/4] usb: gadget: pxa27x_udc: use devm_* helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 06/29/2014 06:01 PM, Robert Jarzmik wrote:

Use devm_* helpers in the probe function to simplify the error path and
the remove path.

Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>
Cc: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>

---
Since V1: Addressed Sergei's comments
---
  drivers/usb/gadget/pxa27x_udc.c | 57 +++++++++++------------------------------
  1 file changed, 15 insertions(+), 42 deletions(-)

diff --git a/drivers/usb/gadget/pxa27x_udc.c b/drivers/usb/gadget/pxa27x_udc.c
index f814795..04aced8 100644
--- a/drivers/usb/gadget/pxa27x_udc.c
+++ b/drivers/usb/gadget/pxa27x_udc.c
@@ -28,12 +28,11 @@
  #include <linux/of_gpio.h>

  #include <asm/byteorder.h>
-#include <mach/hardware.h>

  #include <linux/usb.h>
  #include <linux/usb/ch9.h>
  #include <linux/usb/gadget.h>
-#include <mach/udc.h>
+#include <linux/platform_data/pxa2xx_udc.h>

  #include "pxa27x_udc.h"


   These seem like unrelated changes that should be in a separate patch?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux