On Fri, Jun 27, 2014 at 08:55:31AM -0700, Doug Anderson wrote: > Felipe, > > On Fri, Jun 27, 2014 at 8:46 AM, Felipe Balbi <balbi@xxxxxx> wrote: > > On Thu, Jun 26, 2014 at 11:09:37AM +0530, Sachin Kamat wrote: > >> EHCI and OHCI drivers on Exynos platforms do not work without their > >> corresponding SoC specific phy drivers. Hence it makes no sense to > >> keep these phy drivers as user selectable. Instead select them from > >> the respective USB configs to make things easier for the end user. > >> While at it enable 5250 phy for Exynos 5420 SoC too. > >> > >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxxx> > >> Cc: Kishon Vijay Abraham I <kishon@xxxxxx> > > > > no more selects, please. We've already had way too many issues because > > of misused selects. > > I'll admit to not having been involved with the previous discussions, > but this seems strange to me. Are we throwing in the towel and > deciding that it's too hard to get the Kconfigs right and that we'll > just rely on individual users to figure out the right answer for > themselves? no. select prevents a driver from be built as a dynamically linked module and distro-kernels might want to enable everything as modules. > Certainly the Exynos USB driver is not useful without the Exynos USB > Phy driver, so it seems awfully strange to allow the user to select > one without getting the other... ...and if including an extra USB Phy > driver will break something then it seems like we have bigger problems > (aren't we supposed to have one kernel that works across a wide > variety of boards?) yeah, but for the kernel to "work" it doesn't depend on the PHY driver, does it ? The USB parts of the SoC depend on the PHY, but even PHY drivers should be allowed to be built as modules. Find another way -- balbi
Attachment:
signature.asc
Description: Digital signature
