On Fri, Jun 27, 2014 at 11:25:07AM +0800, Peter Chen wrote: > On Tue, Jun 24, 2014 at 12:35:16PM +0200, Antoine Ténart wrote: > > Add a generic ChipIdea driver, with optional PHY and clock, to support > > ChipIdea controllers that doesn't need specific functions. > > > > + return 0; > > +} > > + > > +static const struct of_device_id ci_hdrc_generic_of_match[] = { > > + { .compatible = "chipidea-usb" }, > > + { } > > +}; > > Even as a generic driver, you can also use your own compatible string. > > > +MODULE_DEVICE_TABLE(of, ci_hdrc_generic_of_match); > > + > > +static struct platform_driver ci_hdrc_generic_driver = { > > + .probe = ci_hdrc_generic_probe, > > + .remove = ci_hdrc_generic_remove, > > + .driver = { > > + .name = "chipidea-usb", > > + .owner = THIS_MODULE, > > + .of_match_table = ci_hdrc_generic_of_match, > > + }, > > +}; > > +module_platform_driver(ci_hdrc_generic_driver); > > + > > +MODULE_DESCRIPTION("Generic ChipIdea HDRC USB binding"); > > +MODULE_AUTHOR("Antoine Ténart <antoine.tenart@xxxxxxxxxxxxxxxxxx>"); > > +MODULE_LICENSE("GPL"); > > -- > > 1.9.1 > > > > -- > Besides, I haven't seen dma_coerce_mask_and_coherent API calling, where you set your dma mask? -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html