Hello there,
----------------------------------------
> The invalid value that should not be let through is 0x3 (4 transactions
> per microframe).
> --- a/drivers/usb/gadget/gr_udc.c
> +++ b/drivers/usb/gadget/gr_udc.c
> @@ -1532,7 +1532,7 @@ static int gr_ep_enable(struct usb_ep *_ep,
> "%s mode: multiple trans./microframe not valid\n",
> (mode == 2 ? "Bulk" : "Control"));
> return -EINVAL;
> - } else if (nt == 0x11) {
> + } else if (nt == 0x3) {
> dev_err(dev->dev, "Invalid value for trans./microframe\n");
> return -EINVAL;
> } else if ((nt + 1) * max> buffer_size) {
> --
> 1.7.10.4
When some value is out of band, I usually try to arrange that
the error message shows the value and, if possible, the band limits.
Suggest rework error message in call to dev_err. Maybe
dev_err(dev->dev, "Invalid value '0x3' for transactions per microframe\n");
would be better.
Regards
David Binderman
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
