On Fri, 2014-06-20 at 23:10 +0000, Paul Zimmerman wrote: > > From: dinguyen@xxxxxxxxxx [mailto:dinguyen@xxxxxxxxxx] > > Sent: Friday, June 20, 2014 8:35 AM > > > > From: Dinh Nguyen <dinguyen@xxxxxxxxxx> > > > > Apologies for the noise, but I got Paul Zimmerman's address wrong on the > > first send. > > > > Hi, > > > > This patch series combines the dwc2 host and gadget driver into a single > > dual-role driver. I have tested this on the SOCFPGA platform. I compile > > tested for bcm2835_defconfig and a PCI platform. > > > > I split up the patches to make the review a bit easier, but each individual > > patch can't really stand on it's own. Any comments/testing is greatly > > appreciated. > > Hi Dinh, > > I really appreciate your work on this, and from a quick glance, it looks > like this will be acceptable once a few issues are taken care of. > > However, I am not going to do an in-depth review, or do any testing, > until you submit a patch series that can be applied. > > Why? If I do a review and test of this series, then I will have to ask > you to redo it into a form that can be applied. Then I would have to do > a full review and test of _that_ series as well, to make sure that > nothing got broken in the translation. So you are creating more work for > me, yourself, and anyone else who might want to review/test this. > > Also, please do not post a patch series titled "[PATCH]" if you know > that it should not be applied as-is. At least put an "RFC" in there so > people will know it shouldn't be applied. > Yes, apologies. I didn't think this patch series needed an RFC as the the idea of this patch has been floating around for a while. And because this patch series is just a respin of earlier efforts. Each patch can be applied cleanly, but will not compile for different Kconfig options, as I'm finding out from kbuild test robot. I need to rework this series so that each patch will compile and maintain bisectability. > Really, you should learn to use git properly, instead of doing a bunch of > work without it, and then throwing everything in at the last minute so > you can create a patch series. Git should be your friend, not your enemy ;) > You'd think that if I knew to add "RESEND" to my patch, I'd know to add "RFC". I've been using git for quite some time now, and this is the 2nd time that called out my "git" skills. Not sure how this oversight and haste in my part could have been solved by git? Dinh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
