On Wed, Jun 18, 2014 at 07:13:19PM +0800, 刘磊 wrote:
>
> dear linuxfoundation:
> Because of the usb driver parameters error that leads to failed in
> reconnect. now i want to modify the error parameter and
> move device pid fffe from zte_ev.c back to option.c for our company.
These are two different changes and should be submitted as two different
patches.
Please make sure to read Documentation/SubmittingPatches before
resubmitting. Greg has asked you to do so at least twice already, but
your patch still does not even apply.
Specifically, make sure to run your patches through
scripts/checkpatch.pl before submitting.
> modify reason:
> 1. Move device pid fffe from zte_ev.c back to option.c for our company.
Why is this needed for this particular PID?
Have a look at commit 52d0dc7597c8 ("usb: serial: zte_ev: move support
for ZTE AC2726 from zte_ev back to option") for an example of what such
a patch could look like.
> 2. Modify the parameter from 0x0003 to 0x0000. the problem may cause
> the device can not be close.
Why is this needed? Can you be more specific? What does this particular
command do?
Thanks,
Johan
> these two points are in the patch, please submit it for me. thanks.
>
>
>
>
> Signed-off-by:lei liu<liu.lei78@xxxxxxxxxx>
> diff -u -r drivers-old/usb/serial/option.c drivers/usb/serial/option.c
> --- drivers-old/usb/serial/option.c 2014-06-17 04:44:27.000000000 +0800
> +++ drivers/usb/serial/option.c 2014-06-18 15:19:21.936561280 +0800
> @@ -1542,6 +1542,7 @@
> { USB_VENDOR_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xff, 0x02, 0x05) },
> { USB_VENDOR_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xff, 0x86, 0x10) },
> { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, ZTE_PRODUCT_AC2726, 0xff, 0xff, 0xff) },
> + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xfffe, 0xff, 0xff, 0xff) },
>
> { USB_DEVICE(BENQ_VENDOR_ID, BENQ_PRODUCT_H10) },
> { USB_DEVICE(DLINK_VENDOR_ID, DLINK_PRODUCT_DWM_652) },
> Only in drivers/usb/serial: option.c~
> diff -u -r drivers-old/usb/serial/zte_ev.c drivers/usb/serial/zte_ev.c
> --- drivers-old/usb/serial/zte_ev.c 2014-06-17 04:44:27.000000000 +0800
> +++ drivers/usb/serial/zte_ev.c 2014-06-18 15:03:47.176597158 +0800
> @@ -257,12 +257,12 @@
>
> /* send 8th cmd */
> /*
> - * 16.0 CTL 21 22 03 00 00 00 00 00
> + * 16.0 CTL 21 22 00 00 00 00 00 00
> */
> len = 0;
> result = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
> 0x22, 0x21,
> - 0x0003, 0x0000, NULL, len,
> + 0x0000, 0x0000, NULL, len,
> USB_CTRL_GET_TIMEOUT);
> dev_dbg(dev, "result = %d\n", result);
>
> @@ -274,8 +274,6 @@
> static const struct usb_device_id id_table[] = {
> /* AC8710, AC8710T */
> { USB_DEVICE_AND_INTERFACE_INFO(0x19d2, 0xffff, 0xff, 0xff, 0xff) },
> - /* AC8700 */
> - { USB_DEVICE_AND_INTERFACE_INFO(0x19d2, 0xfffe, 0xff, 0xff, 0xff) },
> /* MG880 */
> { USB_DEVICE(0x19d2, 0xfffd) },
> { USB_DEVICE(0x19d2, 0xfffc) },
> Only in drivers/usb/serial: zte_ev.c~
>
>
>
>
>
> N?????r??y????b?X??ǧv?^?){.n?+????{??????^n?r???z???h?????&?? ?G???h?(?階?ݢj"???m??????z?ޖ???f???h???~?m
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
