usb/gadget/gr_udc.c:1528: possible bad test ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello there,

[linux-3.16-rc1/drivers/usb/gadget/gr_udc.c:1528] -> [linux-3.16-rc1/drivers/usb/gadget/gr_udc.c:1535]: 
(style) Mismatching assignment and comparison, comparison 'nt==17' is always false.

Source code is

    nt = 0x3 & (usb_endpoint_maxp(desc)>> 11);
    buffer_size = GR_BUFFER_SIZE(epctrl);
    if (nt && (mode == 0 || mode == 2)) {
        dev_err(dev->dev,
            "%s mode: multiple trans./microframe not valid\n",
            (mode == 2 ? "Bulk" : "Control"));
        return -EINVAL;
    } else if (nt == 0x11) {

If nt has been ANDed with 0x3, then it can't have a value of 0x11.
Suggest code rework.

Regards

David Binderman



 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux