On Sun, 2014-06-15 at 18:02 -0400, Alan Stern wrote: > On Sun, 15 Jun 2014, Joe Perches wrote: > > > Use the zeroing function instead of dma_alloc_coherent & memset(,0,) > > > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > > ... > > > diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c > > index 27f35e8..681fc5e 100644 > > --- a/drivers/usb/host/uhci-hcd.c > > +++ b/drivers/usb/host/uhci-hcd.c > > @@ -589,15 +589,14 @@ static int uhci_start(struct usb_hcd *hcd) > > uhci->dentry = dentry; > > #endif > > > > - uhci->frame = dma_alloc_coherent(uhci_dev(uhci), > > - UHCI_NUMFRAMES * sizeof(*uhci->frame), > > - &uhci->frame_dma_handle, 0); > > + uhci->frame = dma_zalloc_coherent(uhci_dev(uhci), > > + UHCI_NUMFRAMES * sizeof(*uhci->frame), > > + &uhci->frame_dma_handle, 0); > > Please don't change the coding style. This file indents continuation > lines by two tab stops; it doesn't align things with opening parens. Convert it to style of your choice. Anyway, there are a lot of instances of alignment to parens in drivers/usb/ than not. Also, that last argument 0 should be GFP_KERNEL -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
