Jingoo Han <jg1.han@xxxxxxxxxxx> writes: > On Tuesday, June 10, 2014 4:52 AM, Robert Jarzmik wrote: >> >> Add support for device-tree device discovery. If devicetree is not >> provided, fallback to legacy platform data "discovery". >> +#include <mach/hardware.h> > > I don't think that this 'hardware.h' is necessary. > Let me know the reason why this header file is added. Debug leftover, good point. Will be removed in v2. >> >> #include <linux/usb.h> >> #include <linux/usb/ch9.h> >> #include <linux/usb/gadget.h> >> +#include <mach/udc.h> > > How about renaming and moving this 'udc.h' to 'include/linux/usb/' > directory, and including '#include <linux/usb/pxa-udc.h>'? > In this case, it enhances build coverage. So, regardless of the > machine dependency, this driver file 'pxa27x_udc.c' can be built. Actually, I'll change it by : #include <linux/platform_data/pxa2xx_udc.h> The build coverage will be still enhanced, and the true purpose is clearer : provide the platform data structure for legacy boards Thanks for the review. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
