Re: [PATCH] usb: gadget: dummy_hcd: remove superfluous setting HC_STATE_RUNNING in dummy_start()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 06/05/2014 10:55 PM, Pantelis Koukousoulas wrote:

After commit 4814030ce11f08350b7, the core now sets

    Please also specify that commit's summary line in parens.

Is this in order to be able to grep it more easily? I 'm asking because

It's actually the only way to uniquely identify the commit as the SHA1 IDs can coincide for the different commits.

that summary (Initialize hcd->state roothubs) doesn't seem to add
much to the rationale otherwise.

It's anyway a lot more info about the commit's nature than just a bare SHA1 ID. Unfortunately with switching from gitweb to cgit you can't jump to a commit clicking on its SHA1 ID anymore when browsing a git repo...

Cheers,
Pantelis

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux