>> -struct usb_functionfs_descs_head {
>> - __le32 magic;
>> - __le32 length;
>> - __le32 fs_count;
>> - __le32 hs_count;
>> -} __attribute__((packed));
On Wed, Jun 04 2014, Krzysztof Opasiak <k.opasiak@xxxxxxxxxxx> wrote:
> I have tried to compile FFS examples with v3.15-rc8 but I have faced an
> issue that they are unable to build due to missing definition of this
> structure.
https://lkml.org/lkml/2014/5/21/522
> The same is with adb, sdb and all userspace apps which use legacy
> API. What is the reason of removing it? Was your intentions?
It was a mistake on my part.
> Maybe would be a good idea to leave this structure untouched as legacy
> userspace API?
I don't care either way to be honest. I guess if there's non-negligible
number of usb_functionfs_descs_head structure users out there, I can
prepare a CL adding the structure back.
> There is also no structure definition for new API, maybe suitable
> structure should be defined (struct usb_functionfs_descs_head2 for
> example) to make userspace life easier?
That structure would not have many fields though, since what exactly the
header contains depends on the flags. Whether fs_count, hs_count and
ss_count fields are present depends on which bits in the flags are set.
So the usb_functionfs_descs_head2 structure could only contain:
struct usb_functionfs_descs_head2 {
__le32 magic;
__le32 length;
__le32 flags;
};
I'm not sure if that would be particularly helpful.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@xxxxxxxxxx>--<xmpp:mina86@xxxxxxxxxx>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
