Re: [PATCH v2 4/4] usb: move hub power management routines to hub_pm.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 3, 2014 at 11:50 AM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, 3 Jun 2014, Dan Williams wrote:
>
>> On Tue, Jun 3, 2014 at 8:51 AM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
>> > On Tue, Jun 3, 2014 at 8:39 AM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
>> >> On Mon, 2 Jun 2014, Dan Williams wrote:
>> [..]
>> >>>  static inline bool usb_device_supports_ltm(struct usb_device *udev)
>> >>>  {
>> >>>       if (udev->speed != USB_SPEED_SUPER || !udev->bos || !udev->bos->ss_cap)
>> >>
>> >> Why didn't you move this definition along the declarations above?
>> >>
>> >
>> > Oversight.
>>
>> On closer look, drivers/usb/core/sysfs.c needs this, so it should stay put.
>
> ?  sysfs.c can get it from "usb.h".  It doesn't need to be in
> <linux/usb.h>.
>

Oversight.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux