On 05/23/2014 04:30 AM, Âí´º wrote:
> hello,
> about the following function, in the last line, it should be "DIV_ROUND_UP", not
> "roundup".
> please have a check!
>
> Transfer Burst Count (TBC). This field identifies number of bursts - 1 that
> shall be required to
> move this Isoch TD. All bursts except the last shall transfer Max Burst Size
> packets. The last
> burst shall transfer TLBPC + 1 packets. Refer to section 4.11.2.3 for more
> information.
>
> static unsigned int xhci_get_burst_count(struct xhci_hcd *xhci,
> struct usb_device *udev,
> struct urb *urb, unsigned int total_packet_count)
> {
> unsigned int max_burst;
>
> if (xhci->hci_version < 0x100 || udev->speed != USB_SPEED_SUPER)
> return 0;
>
> max_burst = urb->ep->ss_ep_comp.bMaxBurst;
> return roundup(total_packet_count, max_burst + 1) - 1;
> }
>
I think you are right.
Do you want to send a proper patch that fixes this?
If not, then I'll just fix it
Thanks
-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
