Re: [PATCH] xhci: Switch only Intel Lynx Point-LP ports to EHCI on shutdown.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Denis,

thank you very much, works fine !

But my diff to the original xhcp-pci.c of Kernel 3.14.4 is:

$ diff xhci-pci.c-original xhci-pci.c-changed
137,138d136
<
<               xhci->quirks |= XHCI_SPURIOUS_REBOOT;
139a138,141
>       if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
>               pdev->device == PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_XHCI) {
>               xhci->quirks |= XHCI_SPURIOUS_REBOOT;
>       }

just fyi

regards Wulf

Am 20.05.2014 13:00, schrieb Denis Turischev:
> Patch "xhci: Switch Intel Lynx Point ports to EHCI on shutdown."
> commit c09ec25d3684cad74d851c0f028a495999591279 is not fully correct
>
> It switches both Lynx Point and Lynx Point-LP ports to EHCI on shutdown.
> On some Lynx Point machines it causes spurious interrupt,
> which wake the system: bugzilla.kernel.org/show_bug.cgi?id=76291
>
> On Lynx Point-LP on the contrary switching ports to EHCI seems to be
> necessary to fix these spurious interrupts.
>
> Signed-off-by: Denis Turischev <denis@xxxxxxxxxxxxxx>
> Reported-by: Wulf Richartz <wulf.richartz@xxxxxxxxx>
> ---
>  drivers/usb/host/xhci-pci.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 08a5f92..d25987e 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -134,7 +134,9 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>  		 */
>  		if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
>  			xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
> -
> +	}
> +	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> +		pdev->device == PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_XHCI) {
>  		xhci->quirks |= XHCI_SPURIOUS_REBOOT;
>  	}
>  	if (pdev->vendor == PCI_VENDOR_ID_ETRON &&

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux