On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote: > Instead of octal notation, to be consistent around the file. > > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> > --- > drivers/usb/gadget/net2280.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c > index c3205ec..5b2ab68 100644 > --- a/drivers/usb/gadget/net2280.c > +++ b/drivers/usb/gadget/net2280.c > @@ -111,7 +111,7 @@ module_param(use_msi, bool, S_IRUGO); > static ushort fifo_mode = 0; > > /* "modprobe net2280 fifo_mode=1" etc */ > -module_param (fifo_mode, ushort, 0644); > +module_param(fifo_mode, ushort, S_IRUGO | S_IWUSR); I don't think this is necessary, in and of itself. In my opinion, the macros are a lot harder to figure out than the octal values. Don't bother making this change. It's useless churn. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html