On Wed, May 14, 2014 at 10:01:17AM +0300, Ivan T. Ivanov wrote: > On Tue, 2014-05-13 at 23:20 +0300, Dan Carpenter wrote: > > Hello Ivan T. Ivanov, > > > > The patch 6b99c68ec1f9: "usb: phy: msm: Migrate to Managed Device > > Resource allocation" from Apr 28, 2014, leads to the following static > > checker warning: > > > > drivers/usb/phy/phy-msm-usb.c:1590 msm_otg_probe() > > warn: 'motg->regs' isn't an ERR_PTR > > > > drivers/usb/phy/phy-msm-usb.c > > 1587 > > 1588 res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > 1589 motg->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); > > 1590 if (IS_ERR(motg->regs)) > > > > Should be a check for NULL. > > True. Thanks. Patch is welcome :-) > Sure, no problem. I'll send a patch. You would probably think reporting the bug and fixing it require the same effort... But yesterday I had the flu so I was able to measure effort with greater accuracy. Feeling better today though. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
