On Tuesday 13 May 2014 10:28:29 Felipe Balbi wrote: > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > > index 151901c..3473296 100644 > > --- a/drivers/usb/host/xhci-plat.c > > +++ b/drivers/usb/host/xhci-plat.c > > @@ -202,7 +202,7 @@ static int xhci_plat_remove(struct platform_device *dev) > > return 0; > > } > > > > -#ifdef CONFIG_PM > > +#ifdef CONFIG_PM_SLEEP > > can we just drop the ifdeferry altogether, including from SET_*_OPS > macros ? This is just ridiculous that every merge window we have tens of > patches fixing the ifdef in several drivers. That would work for me. Another suggestion that came up before was to change the SET_*_OPS so that the compiler silently drops the unused functions, but unfortunately that would require changing all drivers. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html