Hi, On Fri, May 09, 2014 at 11:25:46AM +0530, Pratyush Anand wrote: > On Tue, May 06, 2014 at 02:22:12PM +0800, Amit VIRDI wrote: > > On 5/6/2014 12:56 AM, Felipe Balbi wrote: > > >> I understand that enabling XferInProgress event for bulk/interrupt > > >> >transfers will completely > > >> >change the design of the dwc3 driver and hence is not the viable solution > > >> >to the issue here. > > > just send a patch enabling XferInProgress.. I haven't gotten to it yet. > > > If you beat me to it, more power for you;-) > > > > Enabling XferInProgress event for bulk and interrupt would incur > > significant testing efforts. Till it is done can we revert this patch as > > it isn't correct conceptually? > > Its not just enabling the xferinprogress event for bulk and interrupt > and things will start working. DWC3 driver has been written in such a > way that it handle all isoc transfer using xferinprogress event and > other transfers using xfercomplete event. So you will have to make > changes at couple of more places to get that working and then a through > stress testing. > > @Felip: As per my understanding too, this patch must be reverted. > Enabling IOC for bulk and interrupt without enabling xferinprogress > for them does not make sense. it also causes no extra overhead because the event won't fire anyway. -- balbi
Attachment:
signature.asc
Description: Digital signature
