Hi, On Tue, May 13, 2014 at 10:45:15AM +0200, Andrzej Pietrasiewicz wrote: > Dear All - in general, > @Felipe - in particular, > > I would like to ask your opinion on rearranging the way the source code files > are located in the drivers/usb/gadget directory. > > These are the reasons for doing such a change: > > - there are ~130 source code files already in a clean tree > > - when all gadgets and some udc drivers are built as modules then, > including the by-products of the build (*.o, *.ko, *.mod.c, .*.cmd), > the number easily grows to ~500 files > > - files serving different purpose (udc chip drivers, actual gadget functions' > implementations, legacy gadgets) are located side-by-side which might cause > confusion > > - gadget's Kconfig and Makefile tend to be lengthy. > > What I suggest is to create separate subdirectories: > > - "udc" for UDC chip drivers > - "function" for actual usb functions' implementations > - "legacy" for gadgets compiled as statically composed modules > > while at the gadget's root level there are files related to the composite > framework. > > After the patches are applied the gadget subdirectory looks much cleaner. > > What I would like to ask is: > > 1) Do you find the idea useful? sure, but please regerenate the patches with rename detection (-C -M)... that'll be a lot easier to review. -- balbi
Attachment:
signature.asc
Description: Digital signature
