On 05/12/2014 08:36 PM, Thomas Petazzoni wrote:
Dear Mathias Nyman,
On Mon, 12 May 2014 20:24:45 +0300, Mathias Nyman wrote:
+int xhci_mvebu_mbus_init_quirk(struct platform_device *pdev)
+{
+ struct resource *res;
+ void __iomem *base;
+ const struct mbus_dram_target_info *dram;
Hi
Sparse warns about this:
drivers/usb/host/xhci-mvebu.c:42:5: warning: symbol 'xhci_mvebu_mbus_init_quirk'
was not declared. Should it be static?
Not, it should not: it gets called from xhci-plat.c. However,
xhci-mvebu.c should include its header xhci-mvebu.h so that sparse
realize that the function is voluntarily exported, and that therefore
not having the static qualifier is expected.
Should we resend a v6 with just this change?
Not if this is the only thing that needs fixing.
But if you anyway need to make a new version (Kishon had some remarks) then please
include the header to xhci-mvebu at the same time.
-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
