RE: [PATCH 0/3] libusbg: Fix potential issues found with coverity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Please excuse me but I have missed this question yesterday.

 
> From: Philippe De Swert <philippe.deswert@xxxxxxxxxxxxxxx>
> 
> This patch series fixes a number of issues found with coverity in
> libusbg
> A pull request has also be made:
> https://github.com/libusbg/libusbg/pull/4
> 
> There is one potential remaing potential memory leak in the
> usbg_add_config_function.
> We could leak b there, but I am not sure if it actually is saved in
> some list and is freed
> somewhere else.
> 

If you are talking about b returned from usbg_get_binding() don't be
afraid because it is only pointer to value stored in c->bindings list.
Then, in usbg_add_config_function() new b is allocated and we try to
create suitable symbolic link. If it fails b is freed in this function
otherwise it is added to c->bindings list using
INSERT_TAILQ_STRING_ORDER() macro. The whole list is freed in
usbg_free_config() while removing whole configuration and in suitable
places like removing function from configuration - usbg_rm_binding() (in
pending patches). 

--
BR's
Krzysztof Opasiak


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux